Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds a smaller size targeting strategy, makes crabs use them #1105

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25603
Original PR: tgstation/tgstation#80246

About The Pull Request

The PR that added crabs said crabs are now small creatures, and will hunt tiny creatures. However, their targeting strategy was our_our_smaller, so a group of crabs ended up eating each other. This PR creates a new targeting strategy, and applies it to the crab AI.

Why It's Good For The Game

Puts an end to crabbibalism.

Changelog

🆑 Profakos
fix: Crabs will properly only target Tiny creatures
/:cl:

… [MDB IGNORE] (#25603)

* Adds a smaller size targeting strategy, makes crabs use them (#80246)

## About The Pull Request

The PR that added crabs said crabs are now small creatures, and will
hunt tiny creatures. However, their targeting strategy was
`our_our_smaller`, so a group of crabs ended up eating each other. This
PR creates a new targeting strategy, and applies it to the crab AI.

## Why It's Good For The Game

Puts an end to crabbibalism.

## Changelog

:cl:
fix: Crabs will properly only target Tiny creatures
/:cl:

* Adds a smaller size targeting strategy, makes crabs use them

---------

Co-authored-by: Profakos <[email protected]>
@Iajret Iajret merged commit d80ab35 into master Dec 14, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25603 branch December 14, 2023 00:27
AnywayFarus added a commit that referenced this pull request Dec 14, 2023
Iajret pushed a commit that referenced this pull request Feb 23, 2024
* Fixes arcade cabinets being un-hittable (#81620)

## About The Pull Request

What if we put all of our item based interactions in the same function
that attacks are handled? Great idea, I'm sure no one will ever forget
to call parent

Fixes that. 

Also cleans up ticket code. 

Also renames the base type so mappers stop mapping it in. 

## Changelog

:cl: Melbert
fix: You can now take our your anger upon arcade cabinets upon losing
(they can be hit again)
/:cl:

* Fixes arcade cabinets being un-hittable

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants